feat: make foreground service opt-in by jvsena42 · Pull Request #1053 · synonymdev/bitkit-android

jvsena42 · 2026-06-29T17:08:02Z

Fixes #1007

This PR:

Adds a "Keep Bitkit active in background" toggle to the Background Payments screen that makes the persistent foreground service opt-in and disabled by default. The Lightning node still runs while the app is open, and background payments still arrive via push notifications; enabling the toggle keeps Bitkit active in the background for more reliable payments, at the cost of a persistent notification.
Updates the Background Payments screen and the notification preview to match the latest design.
Always shows the amount in payment notifications and removes the "Include amount in notifications" option.
Fixes a Lightning event-handler leak so toggling the service on and off no longer accumulates stale handlers.

Description

New persisted setting, off by default. The foreground service start gate now also requires it, and turning it off stops a running service immediately so the persistent notification disappears at once.
Stopping the foreground service no longer stops the in-app node when an activity is active; in the foreground the node lifecycle is owned by the wallet view model, so toggling the service off leaves the node running. When the app is backgrounded, the node still stops as before.
The Background Payments screen is reordered to match the design: "Get paid when Bitkit is closed", "Keep Bitkit active in background", a Notifications section with the Customize button, and a Preview of the payment notification. The "Keep Bitkit active in background" switch is disabled while notifications are denied.
The notification preview is redesigned to the Android notification card style, with the app icon, title, time, amount, and an expand chevron.
Removed the show-notification-details setting and its privacy toggle. Payment notifications now always include the amount across the foreground service, in-app handler, and the background push path.
Added a remove-event-handler API and de-register the foreground service handler when the service is destroyed, preventing stale handlers from accumulating across service restarts.

Preview

disable-fg-switch.webm

disable-notifications.webm

running-from-master.webm

wake-to-pay.webm

enable-fg-service.webm

QA Notes

FIGMA

Manual Tests

1. Settings → Background Payments: "Keep Bitkit active in background" is off by default and no persistent Bitkit notification is shown in the status bar.
2. Background Payments → toggle Keep active on: persistent Bitkit notification appears → background the app: node stays alive.
3. Background Payments → toggle Keep active off: persistent notification disappears immediately → with the app still open, receive a payment: still works (node keeps running).
4. Revoke notification permission in Android settings → Background Payments: "Get paid when Bitkit is closed" reads off and "Keep Bitkit active in background" is disabled.
5. regression: Keep active off, app closed → receive a payment: push notification arrives and shows the amount.
6. Background Payments: layout matches the design (two switches with explanations, Notifications/Customize, Preview card).

Automated Checks

Unit tests added: default value and setter for the new toggle in SettingsViewModelTest.kt.
Test coverage removed: hidden-amount assertions deleted from ReceivedNotificationContentTest.kt and NotifyChannelReadyHandlerTest.kt because the show-notification-details option no longer exists; SettingsData stubs updated in NotifyPaymentReceivedHandlerTest.kt.
Ran locally: just compile, the affected unit tests, and just lint.
CI: standard compile, unit test, and detekt checks run by the PR bot.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9a98728be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ll true

ovitrif

Reviewed locally. I left two comments: one lifecycle issue around the background transition, and one changelog cleanup. Leaving this as a neutral review.

ovitrif · 2026-06-30T16:20:57Z

                Lifecycle.Event.ON_STOP -> {
-                    if (walletExists && !isRecoveryMode && !notificationsGranted) {
-                        // App backgrounded without notification permission - stop node
+                    val keptAliveByService = notificationsGranted && keepActiveInBackground


I think this observer can use stale notificationsGranted and keepActiveInBackground values because the effect is keyed only by lifecycle. If the user toggles Keep Bitkit active during the same activity session, the next ON_STOP can still follow the old setting and either stop the node despite the service being enabled or leave it running after the service was disabled. Could we keep these values current inside the observer, for example with rememberUpdatedState or by recreating the effect when they change?

ovitrif · 2026-06-30T16:20:57Z

@@ -0,0 +1 @@
+Background payments now include a "Keep Bitkit active in background" option for more reliable payments.


Could we rename this fragment to 1053.added.md and update the text to also mention that payment notifications now always include the amount? The collection script only appends the PR reference when the fragment ref is numeric, and this PR removes the previous hidden-amount behavior.

ovitrif

tAck. The two comments from my previous review are more like nits, the first one didn't really repro in my tests.

jvsena42 added 4 commits June 29, 2026 13:36

feat: make background fg service opt-in

4333203

feat: implement remove event handler logic to avoid leak

602fc59

feat: feat: match figma on background payments screen

3ab09d0

refactor: always show amount in payment notifications

b9a9872

jvsena42 self-assigned this Jun 29, 2026

jvsena42 marked this pull request as ready for review June 29, 2026 20:35

This comment was marked as outdated.

Sign in to view

greptile-apps Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/MainActivity.kt

Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt Outdated

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Comment thread app/src/main/java/to/bitkit/ui/MainActivity.kt Outdated

Comment thread app/src/main/java/to/bitkit/ui/MainActivity.kt

jvsena42 added 5 commits June 30, 2026 07:03

refactor: drop redundant run

9db5953

fix: stop service when notification is disabled and keepActive is sti…

ea1f74a

…ll true

fix: stop node onTimeOut only when is in BG

c075bca

refactor: remove unnecessary map

80fd775

Merge branch 'master' into feat/fg-service-optional

36d69cb

jvsena42 requested review from ovitrif and piotr-iohk June 30, 2026 11:17

ovitrif added this to the 2.4.0 milestone Jun 30, 2026

jvsena42 enabled auto-merge June 30, 2026 14:39

ovitrif reviewed Jun 30, 2026

View reviewed changes

ovitrif approved these changes Jun 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: make foreground service opt-in#1053

feat: make foreground service opt-in#1053
jvsena42 wants to merge 9 commits into
masterfrom
feat/fg-service-optional

jvsena42 commented Jun 29, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

ovitrif left a comment

Uh oh!

ovitrif Jun 30, 2026

Uh oh!

ovitrif Jun 30, 2026

Uh oh!

ovitrif left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1 @@
		Background payments now include a "Keep Bitkit active in background" option for more reliable payments.

Uh oh!

Conversation

jvsena42 commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Preview

QA Notes

Manual Tests

Automated Checks

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ovitrif left a comment

Choose a reason for hiding this comment

Uh oh!

ovitrif Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

ovitrif Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

ovitrif left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jvsena42 commented Jun 29, 2026 •

edited

Loading

ovitrif left a comment •

edited

Loading